[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[postgrey] Re: ANNOUNCE: Postgrey 1.21 (SECURITY)


--On Donnerstag, 14. April 2005 23:04 +0200 David Schweikert 
<dws{at}ee{dot}ethz{dot}ch> wrote:

> Hi,
>
> I did just release version 1.21.
>
> Download it here:
>
> http://isg.ee.ethz.ch/tools/postgrey/pub/postgrey-1.21.tar.gz


diff -urN postgrey-1.18/postgrey postgrey-1.21/postgrey
--- postgrey-1.18/postgrey      2005-03-07 05:16:22.000000000 -0500
+++ postgrey-1.21/postgrey      2005-04-14 16:57:20.000000000 -0400

...

@@ -557,7 +559,8 @@
             $self->{postgrey_attr} = {};
         }
         else {
-             $self->{net_server}->log(2, "ignoring garbage: <".substr($in, 
0, 100).">");
+            $in =~ s/\%/_/g; # log uses printf...  <-!!!!!!!
+            $self->{net_server}->log(2, "ignoring garbage: <".substr($in, 
0, 100).">");
         }
     }
 }


Looks like you forgot to replace the second "%" -> "%%" replacement code.


Is
            $in =~ s/\%/_/g; # log uses printf...
should
            $in =~ s/\%/%%/g; # log uses printf...

I'm sure you were in hurry ;-)

	Peter
-- 
Dr. Peter Bieringer                     http://www.bieringer.de/pb/
GPG/PGP Key 0x958F422D               mailto: pb at bieringer dot de
Deep Space 6 Co-Founder and Core Member  http://www.deepspace6.net/

--
Unsubscribe mailto:postgrey-request@list.ee.ethz.ch?subject=unsubscribe
Help        mailto:postgrey-request@list.ee.ethz.ch?subject=help
Archive     http://lists.ee.ethz.ch/postgrey
WebAdmin    http://lists.ee.ethz.ch/lsg2.cgi